FeatureFormView - UI tests for adding UNA associations, warning resolutions, logging improvements, small bug fix
#1309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfeinzimer
changed the title
FeatureFormView - UI tests for adding UNA associationsFeatureFormView - UI tests for adding UNA associations, warning resolutions & logging improvements
dfeinzimer
requested review from
a team,
mhdostal and
yo1995
and removed request for
a team
dfeinzimer
changed the title
FeatureFormView - UI tests for adding UNA associations, warning resolutions & logging improvementsFeatureFormView - UI tests for adding UNA associations, warning resolutions, logging improvements, small bug fix
dfeinzimer
commented
Oct 16, 2025
Comment on lines
-95
to
+98
| case (false, .some, .some): | ||
| case (false, _, _): |
There was a problem hiding this comment.
Fix for Apollo 1461.
dfeinzimer
commented
Oct 16, 2025
Comment on lines
+253
to
+254
| Slider(value: $fractionAlongEdge, in: 0...1) { | ||
| Text(LocalizedStringResource.fractionAlongEdge) |
There was a problem hiding this comment.
Resolves warning Expression of type 'LocalizedStringResource' is unused - wrong symbol was being used.
yo1995
previously approved these changes
Oct 16, 2025
|
|
||
| fractionAlongEdgeSlider.adjust(toNormalizedSliderPosition: 0.75) | ||
|
|
||
| XCTAssertTrue( |
There was a problem hiding this comment.
The test throws an error here when I run it on iOS 26, while passes on iOS 18. No need to fix for now, but may be worth taking a look and see if it can pass on 26 as well.
There was a problem hiding this comment.
It looks like it goes to 78% on iOS 26 and 77% on iOS 18.
Since we're already fighting some other wonkiness in this test case, I will keep it as is for now and re-evaluate when we update test devices to iPadOS 26.
mhdostal
requested changes
Oct 17, 2025
mhdostal
approved these changes
Oct 17, 2025
yo1995
approved these changes
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apollo 1427, 1461, 1469